Remove completely pointless load of every repository when viewing a repository URI
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 8:43 PM.

Details

Reviewers: None
Commits: rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository…

Summary

See D18176. This query has no effect (other than wasting resources) and the result is unused.

$repository already has the URI loaded because we load them unconditionally during request initialization.

Test Plan

Viewed repository URIs.

Diff Detail

Repository

rP Phabricator

Branch

uri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19438
Build 26292: Run Core Tests
Build 26291: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2018, 8:43 PM

epriestley mentioned this in D18176: Correct a datasource issue when viewing repository URIs in "Manage Repository".Feb 8 2018, 8:43 PM

Harbormaster completed remote builds in B19438: Diff 45643.Feb 8 2018, 8:44 PM

epriestley requested review of this revision.Feb 8 2018, 8:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 8:47 PM

Closed by commit rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

(T6928 could have caught this statically.)

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryURIViewController.php

6 lines

Diff 45643

View Options

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Remove completely pointless load of every repository when viewing a repository URIClosedPublicActions