Page MenuHomePhabricator
Differential D19036

Remove completely pointless load of every repository when viewing a repository URI
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 8:43 PM.
Tags
None
Referenced Files
F18584913: D19036.id45644.diff
Thu, Sep 11, 2:03 PM
F18566571: D19036.id.diff
Tue, Sep 9, 2:44 PM
F18502098: D19036.diff
Thu, Sep 4, 10:11 PM
F18374752: D19036.id45643.diff
Thu, Aug 28, 9:11 AM
F18370907: D19036.id45644.diff
Thu, Aug 28, 4:23 AM
F18370722: D19036.id45644.diff
Thu, Aug 28, 4:10 AM
F18370692: D19036.id45643.diff
Thu, Aug 28, 4:07 AM
F18370661: D19036.id.diff
Thu, Aug 28, 4:05 AM
View All Files
Subscribers
jmeador

Details

Reviewers
None
Commits
rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository…
Summary

See D18176. This query has no effect (other than wasting resources) and the result is unused.

$repository already has the URI loaded because we load them unconditionally during request initialization.

Test Plan

Viewed repository URIs.

Diff Detail

Repository
rP Phabricator
Branch
uri1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19438
Build 26292: Run Core Tests
Build 26291: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines

Diff 45643

View Options

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Loading...
Phabricator · Built by Phacility