Page MenuHomePhabricator
Differential D19028

Only add the Mail "STAMPS" body section if there are stamps
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:05 PM.
Tags
None
Referenced Files
F14037806: D19028.diff
Sun, Nov 10, 7:18 PM
F14024484: D19028.diff
Thu, Nov 7, 9:50 AM
F13993133: D19028.id45628.diff
Tue, Oct 22, 8:54 PM
F13969530: D19028.id45628.diff
Thu, Oct 17, 2:59 AM
Unknown Object (File)
Oct 9 2024, 8:46 AM
Unknown Object (File)
Oct 2 2024, 6:06 AM
Unknown Object (File)
Sep 22 2024, 10:25 PM
Unknown Object (File)
Sep 22 2024, 8:25 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13053: Plans: Mail Tags and Failover
Commits
rPa8f937d3138a: Only add the Mail "STAMPS" body section if there are stamps
Summary

Ref T13053. Some mail (like push notification mail) doesn't currently generate any stamps. Drop this section if there aren't any stamps on the mail.

Test Plan

Will check push mail in production.

Diff Detail

Repository
rP Phabricator
Branch
mail3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19421
Build 26265: Run Core Tests
Build 26264: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2018, 5:05 PM
Harbormaster completed remote builds in B19421: Diff 45626.Feb 8 2018, 5:06 PM
epriestley requested review of this revision.Feb 8 2018, 5:06 PM
epriestley added a child revision: D19029: Pass HTML bodies to push email.Feb 8 2018, 5:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:09 PM
Closed by commit rPa8f937d3138a: Only add the Mail "STAMPS" body section if there are stamps (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
replyhandler/
43 lines

Diff 45626

View Options

src/applications/metamta/replyhandler/PhabricatorMailTarget.php

Loading...
Phabricator · Built by Phacility