Page MenuHomePhabricator
Differential D18982

Add withNameGlob() to FileFinder
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 10:38 PM.
Tags
None
Referenced Files
F15460128: D18982.id45517.diff
Mon, Mar 31, 8:19 PM
F15459431: D18982.id45521.diff
Mon, Mar 31, 12:52 PM
F15456446: D18982.id.diff
Sun, Mar 30, 9:45 AM
F15453563: D18982.diff
Sat, Mar 29, 12:40 PM
F15417462: D18982.id45521.diff
Thu, Mar 20, 5:08 PM
F15413648: D18982.diff
Wed, Mar 19, 8:19 PM
F15379746: D18982.id.diff
Thu, Mar 13, 11:10 PM
F15375081: D18982.diff
Wed, Mar 12, 9:35 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHUfb082fb35626: (stable) Promote 2018 Week 5
rPHUcc343d0c8133: Add withNameGlob() to FileFinder
Summary

Depends on D18981. See PHI336. Addresses the use case test_*.py in a portable way.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
finder4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19306
Build 26094: Run Core Tests
Build 26093: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 10:38 PM
Harbormaster completed remote builds in B19306: Diff 45517.Jan 31 2018, 10:38 PM
epriestley requested review of this revision.Jan 31 2018, 10:38 PM
amckinley accepted this revision.Jan 31 2018, 10:53 PM
This revision is now accepted and ready to land.Jan 31 2018, 10:53 PM
Closed by commit rPHUcc343d0c8133: Add withNameGlob() to FileFinder (authored by epriestley). · Explain WhyJan 31 2018, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
33 lines
__tests__/
20 lines

Diff 45517

View Options

src/filesystem/FileFinder.php

Loading...
View Options

src/filesystem/__tests__/FileFinderTestCase.php

Loading...
Phabricator · Built by Phacility