Page MenuHomePhabricator

Rewrite FileFinder tests to actually show why they break
ClosedPublic

Authored by epriestley on Jan 31 2018, 9:13 PM.
Tags
None
Referenced Files
F14840901: D18980.diff
Sat, Feb 1, 10:38 AM
Unknown Object (File)
Fri, Jan 24, 11:32 PM
Unknown Object (File)
Fri, Jan 24, 11:32 PM
Unknown Object (File)
Fri, Jan 24, 11:32 PM
Unknown Object (File)
Thu, Jan 23, 3:49 AM
Unknown Object (File)
Tue, Jan 21, 11:29 AM
Unknown Object (File)
Fri, Jan 17, 2:26 PM
Unknown Object (File)
Fri, Jan 17, 1:29 PM
Subscribers
None

Details

Summary

Depends on D18979. Currently, when you break FileFinder you get "test failure! got true, expected false on some random line".

There's no way to see why your change broke stuff, since the assertions are all these very narrow key checks in a result list.

Just test that the entire result list is what we expect so there's a nice diff in the output if you break something. Also, simplify the code.

Test Plan

arc unit is still clean, got sensible test errors while writing this.

Diff Detail

Repository
rPHU libphutil
Branch
finder2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19303
Build 26088: Run Core Tests
Build 26087: arc lint + arc unit