Page MenuHomePhabricator

Mangle cells that look a little bit like formulas in CSV files
ClosedPublic

Authored by epriestley on Jan 31 2018, 12:25 AM.
Tags
None
Referenced Files
F14809778: D18974.diff
Sun, Jan 26, 8:04 PM
Unknown Object (File)
Sat, Jan 25, 1:39 PM
Unknown Object (File)
Fri, Jan 24, 11:31 PM
Unknown Object (File)
Fri, Jan 24, 11:31 PM
Unknown Object (File)
Fri, Jan 24, 11:31 PM
Unknown Object (File)
Fri, Jan 24, 11:31 PM
Unknown Object (File)
Thu, Jan 23, 4:55 AM
Unknown Object (File)
Sat, Jan 18, 1:15 AM
Subscribers
None

Details

Summary

Fixes T12800. See that task for discussion. When a cell in a CSV begins with "=", "+", "-", or "@", mangle the content to discourage Excel from executing it.

This is clumsy, but we support other formats (e.g., JSON) which preserve the data faithfully and you should probably be using JSON if you're going to do anything programmatic with it.

We could add two formats or a checkbox or a warning or something but cells with these symbols are fairly rare anyway.

Some possible exceptions I can think of are "user monograms" (but we don't export those right now) and "negative numbers" (but also no direct export today). We can add exceptions for those as they arise.

Test Plan

Exported a task named =cmd|'/C evil.exe'!A0, saw the title get mangled with "(!)" in front.

Diff Detail

Repository
rP Phabricator
Branch
export10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19294
Build 26072: Run Core Tests
Build 26071: arc lint + arc unit