Page MenuHomePhabricator

Fix an export bug where queries specified in the URI ("?param=value") were ignored when filtering the result set
ClosedPublic

Authored by epriestley on Jan 30 2018, 4:06 PM.
Tags
None
Referenced Files
F13271868: D18969.diff
Thu, May 30, 6:17 AM
F13253371: D18969.diff
Sat, May 25, 2:37 AM
F13239379: D18969.id45491.diff
Wed, May 22, 2:22 AM
F13231923: D18969.diff
Tue, May 21, 12:52 AM
F13215982: D18969.id.diff
Fri, May 17, 9:35 PM
F13214613: D18969.id45491.diff
Fri, May 17, 11:55 AM
F13210825: D18969.diff
Fri, May 17, 5:15 AM
F13194749: D18969.diff
Sun, May 12, 9:51 PM
Subscribers
None

Details

Summary

Depends on D18968. Ref T13049. Currently, if you visit /query/?param=value, there is no queryKey for the page but we build a query later on.

Right now, we incorrectly link to /query/all/export/ in this case (and export too many results), but we should actually link to /query/<constructed query key>/export/ to export only the desired/previewed results.

Swap the logic around a little bit so we look at the query we're actually executing, not the original URI, to figure out the query key we should use when building the link.

Test Plan

Visited a /?param=value page, exported data, got a subset of the full data instead of everything.

Diff Detail

Repository
rP Phabricator
Branch
export5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19279
Build 26051: Run Core Tests
Build 26050: arc lint + arc unit