Add test coverage for SSH key revocation
ClosedPublic
Actions

Authored by epriestley on Jan 25 2018, 2:56 PM.

Tags

None

Referenced Files

	F14759651: D18929.diff
	Wed, Jan 22, 1:33 PM

	F14756716: D18929.id45399.diff
	Tue, Jan 21, 8:20 PM

	Unknown Object (File)
	Tue, Jan 21, 12:57 PM

	Unknown Object (File)
	Tue, Jan 21, 11:08 AM

	Unknown Object (File)
	Sun, Jan 19, 9:00 PM

	Unknown Object (File)
	Fri, Jan 17, 6:47 PM

	Unknown Object (File)
	Tue, Jan 14, 4:09 PM

	Unknown Object (File)
	Sat, Jan 11, 8:35 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13043: Improve authentication revocation behaviors

Commits

rP5529458e14eb: Add test coverage for SSH key revocation

Summary

Depends on D18928. Ref T13043. Add some automated test coverage for SSH revocation rules.

Test Plan

Ran tests, got a clean bill of health.

Diff Detail

Repository

rP Phabricator

Branch

revoke2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19180
Build 25903: Run Core Tests
Build 25902: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 25 2018, 2:56 PM

Harbormaster completed remote builds in B19179: Diff 45398.Jan 25 2018, 2:57 PM

epriestley requested review of this revision.Jan 25 2018, 2:57 PM

More clarity in comments.

Harbormaster completed remote builds in B19180: Diff 45399.Jan 25 2018, 2:59 PM

amckinley accepted this revision.Jan 25 2018, 7:50 PM

This revision is now accepted and ready to land.Jan 25 2018, 7:50 PM

Closed by commit rP5529458e14eb: Add test coverage for SSH key revocation (authored by epriestley). · Explain WhyJan 26 2018, 3:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

auth/

__tests__/

PhabricatorAuthSSHKeyTestCase.php

78 lines

Diff 45399

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/tests/PhabricatorAuthSSHKeyTestCase.php

Add test coverage for SSH key revocationClosedPublicActions