Page MenuHomePhabricator
Differential D18877

Support tokenizer custom fields in bulk editor
ClosedPublic
Actions

Authored by epriestley on Jan 19 2018, 2:43 PM.
Tags
None
Referenced Files
F15410134: D18877.diff
Wed, Mar 19, 6:48 AM
F15408192: D18877.id.diff
Tue, Mar 18, 9:37 PM
F15400305: D18877.diff
Mon, Mar 17, 10:53 AM
F15395914: D18877.diff
Sun, Mar 16, 10:43 AM
F15351870: D18877.diff
Mon, Mar 10, 4:00 PM
F15293881: D18877.id45269.diff
Wed, Mar 5, 5:28 AM
Unknown Object (File)
Fri, Feb 28, 5:40 PM
Unknown Object (File)
Wed, Feb 26, 6:33 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support
Commits
rPb6737554e1ec: Support tokenizer custom fields in bulk editor
Summary

Ref T13025. This allows custom tokenizer fields, like a "Owning Group" field, to be edited with the bulk editor.

See PHI173 for some context.

Test Plan

Edited a custom "Owner" field (a project tokenizer) with the bulk editor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 19 2018, 2:43 PM
Harbormaster completed remote builds in B19053: Diff 45269.Jan 19 2018, 2:44 PM
epriestley requested review of this revision.Jan 19 2018, 2:44 PM
amckinley accepted this revision.Jan 19 2018, 7:42 PM
This revision is now accepted and ready to land.Jan 19 2018, 7:42 PM
Closed by commit rPb6737554e1ec: Support tokenizer custom fields in bulk editor (authored by epriestley). · Explain WhyJan 19 2018, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
editor/
30 lines
field/
27 lines
standard/
7 lines

Diff 45288

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility