Page MenuHomePhabricator

Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits
ClosedPublic

Authored by epriestley on Jan 19 2018, 2:23 PM.
Tags
None
Referenced Files
F14046497: D18876.diff
Wed, Nov 13, 9:33 PM
F14033630: D18876.diff
Sat, Nov 9, 6:44 PM
F14022074: D18876.diff
Wed, Nov 6, 3:10 PM
F13999442: D18876.diff
Thu, Oct 24, 2:47 PM
F13975136: D18876.id45268.diff
Oct 18 2024, 8:56 AM
F13965374: D18876.id45268.diff
Oct 16 2024, 1:38 AM
Unknown Object (File)
Oct 9 2024, 8:27 AM
Unknown Object (File)
Sep 16 2024, 3:00 AM
Subscribers
None

Details

Summary

Ref T13025. Custom field transactions work somewhat unusually: the values sometimes need to be encoded. We currently do not apply this encoding correctly via Conduit.

For example, setting some custom PHID field to ["PHID-X-Y"] fails with a bunch of JSON errors.

Add an extra hook callback so that EditTypes can apply processing to transaction values, then apply the correct CustomField processing.

This only affects Conduit. In a future diff, this also allows bulk edit of custom fields to work correctly.

Test Plan

Added a custom field to Maniphest with a list of projects. Used Conduit to bulk edit it (which now works, but did not before). Used the web UI to bulk edit it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable