Page MenuHomePhabricator
Differential D18877

Support tokenizer custom fields in bulk editor
ClosedPublic
Actions

Authored by epriestley on Jan 19 2018, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 15, 2:15 PM
Unknown Object (File)
Wed, Sep 11, 3:17 AM
Unknown Object (File)
Fri, Sep 6, 1:45 AM
Unknown Object (File)
Fri, Sep 6, 1:45 AM
Unknown Object (File)
Fri, Sep 6, 1:45 AM
Unknown Object (File)
Mon, Sep 2, 6:17 AM
Unknown Object (File)
Tue, Aug 27, 7:28 PM
Unknown Object (File)
Sun, Aug 25, 4:53 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support
Commits
rPb6737554e1ec: Support tokenizer custom fields in bulk editor
Summary

Ref T13025. This allows custom tokenizer fields, like a "Owning Group" field, to be edited with the bulk editor.

See PHI173 for some context.

Test Plan

Edited a custom "Owner" field (a project tokenizer) with the bulk editor.

Diff Detail

Repository
rP Phabricator
Branch
bulk11x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19053
Build 25711: Run Core Tests
Build 25710: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 19 2018, 2:43 PM
Harbormaster completed remote builds in B19053: Diff 45269.Jan 19 2018, 2:44 PM
epriestley requested review of this revision.Jan 19 2018, 2:44 PM
amckinley accepted this revision.Jan 19 2018, 7:42 PM
This revision is now accepted and ready to land.Jan 19 2018, 7:42 PM
Closed by commit rPb6737554e1ec: Support tokenizer custom fields in bulk editor (authored by epriestley). · Explain WhyJan 19 2018, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
editor/
30 lines
field/
27 lines
standard/
7 lines

Diff 45269

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility