Differential D18837
Make "arc land" accommodate a minor API change in Harbormaster build statuses Authored by epriestley on Dec 22 2017, 5:18 PM. Tags None Referenced Files
Subscribers None
Details See PHI261. Currently "arc land" shows every build staus (passed, failed, building, etc) as yellow. Intended behavior is that passed builds are green, failed builds are red, and so on. This is because of an unintended API change a while ago in D16356. Since the only impact was a cosmetic color issue, this escaped notice until now. Additionally, try to use the modern harbormaster.build.search if it is available.
Diff Detail
Event TimelineComment Actions Specifically, the old API result looked like this: 'buildStatus' => 'passed' The newer one looks like this: 'buildStatus' => array( 'value' => 'passed', 'name' => 'Passed', ) That caused the switch() (see inline) to always hit the default case and go yellow.
| ||||||||||||||||||||||||||||||||||||||||