Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 3:47 PM
Unknown Object (File)
Mon, Jan 27, 4:53 PM
Unknown Object (File)
Thu, Jan 23, 2:13 PM
Unknown Object (File)
Wed, Jan 22, 6:56 AM
Unknown Object (File)
Tue, Jan 21, 4:07 PM
Unknown Object (File)
Tue, Jan 21, 10:42 AM
Unknown Object (File)
Tue, Jan 21, 2:41 AM
Unknown Object (File)
Sat, Jan 18, 9:53 PM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Branch
notify
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18967
Build 25580: Run Core Tests
Build 25579: arc lint + arc unit