Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 8:26 PM
Unknown Object (File)
Sat, Feb 22, 3:46 PM
Unknown Object (File)
Sat, Feb 22, 3:44 PM
Unknown Object (File)
Thu, Feb 20, 9:09 PM
Unknown Object (File)
Wed, Feb 19, 1:20 PM
Unknown Object (File)
Sat, Feb 15, 12:05 AM
Unknown Object (File)
Sun, Feb 9, 2:56 AM
Unknown Object (File)
Mon, Feb 3, 2:46 AM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Branch
notify
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18967
Build 25580: Run Core Tests
Build 25579: arc lint + arc unit