Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
F14719836: D18835.id45190.diff
Fri, Jan 17, 9:27 PM
Unknown Object (File)
Mon, Jan 13, 12:32 PM
Unknown Object (File)
Tue, Jan 7, 10:37 AM
Unknown Object (File)
Fri, Dec 27, 12:37 AM
Unknown Object (File)
Sat, Dec 21, 7:50 AM
Unknown Object (File)
Fri, Dec 20, 8:47 PM
Unknown Object (File)
Dec 16 2024, 10:26 AM
Unknown Object (File)
Dec 15 2024, 10:01 PM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Branch
notify
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18967
Build 25580: Run Core Tests
Build 25579: arc lint + arc unit