Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
F18808247: D18835.diff
Sun, Oct 19, 5:45 AM
F18652711: D18835.id45190.diff
Sun, Sep 21, 9:10 AM
F18600385: D18835.diff
Sep 13 2025, 9:37 AM
F18581601: D18835.id45190.diff
Sep 11 2025, 6:29 AM
F18512318: D18835.diff
Sep 5 2025, 7:52 AM
F18460692: D18835.diff
Sep 1 2025, 7:22 PM
F18460551: D18835.diff
Sep 1 2025, 7:13 PM
F18327089: D18835.id.diff
Aug 24 2025, 10:26 PM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Branch
notify
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18967
Build 25580: Run Core Tests
Build 25579: arc lint + arc unit