Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
F19524652: D18835.id45191.diff
Sun, Jan 18, 2:59 AM
F19524651: D18835.id.diff
Sun, Jan 18, 2:59 AM
F19524044: D18835.id45190.diff
Sat, Jan 17, 9:45 PM
F19516063: D18835.diff
Wed, Jan 14, 7:25 PM
F19276910: D18835.id45191.diff
Dec 23 2025, 1:27 AM
F18847370: D18835.diff
Oct 30 2025, 12:17 AM
F18837166: D18835.id45191.diff
Oct 27 2025, 4:35 AM
F18836197: D18835.id.diff
Oct 26 2025, 11:07 PM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Branch
notify
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18967
Build 25580: Run Core Tests
Build 25579: arc lint + arc unit