Page MenuHomePhabricator

Clean up Differential draft mail behaviors
ClosedPublic

Authored by epriestley on Oct 31 2017, 6:53 PM.
Tags
None
Referenced Files
F15549627: D18748.diff
Sun, Apr 27, 6:57 AM
F15531268: D18748.id44998.diff
Wed, Apr 23, 10:26 AM
F15524338: D18748.id44998.diff
Mon, Apr 21, 7:29 AM
F15516444: D18748.diff
Fri, Apr 18, 7:02 PM
F15507982: D18748.id45001.diff
Wed, Apr 16, 12:50 AM
F15507967: D18748.id45004.diff
Wed, Apr 16, 12:45 AM
F15491263: D18748.id45000.diff
Sat, Apr 12, 1:08 AM
F15484209: D18748.id45000.diff
Wed, Apr 9, 5:08 PM
Subscribers
None

Details

Summary

Ref T2543. Fixes two relatively minor things:

  • When builds finish in Harbormaster, send mail "From" the author.
  • Set the firstBroadcast flag so that initial mail picks up earlier history (notably, the "reviewers" line).

For now, I'm not setting firstBroadcast on explicit "Request Review" (but maybe we should), and not trying to deal with weird cases where you leave a bunch of comments on a draft. Those might be fine as-is or may get tweaked later.

Test Plan

Created a revision with Harbormaster builds, ran builds, saw initial email come "From" the right user with more metadata.

Diff Detail

Repository
rP Phabricator
Branch
draft2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18781
Build 25312: Run Core Tests
Build 25311: arc lint + arc unit