Page MenuHomePhabricator

Clean up Differential draft mail behaviors
ClosedPublic

Authored by epriestley on Oct 31 2017, 6:53 PM.
Tags
None
Referenced Files
F19052079: D18748.id.diff
Fri, Nov 28, 2:51 AM
F18966249: D18748.diff
Nov 14 2025, 6:59 PM
F18931331: D18748.diff
Nov 10 2025, 2:48 AM
F18817126: D18748.diff
Oct 21 2025, 12:44 PM
F18808782: D18748.id45001.diff
Oct 19 2025, 8:33 AM
F18783756: D18748.id45001.diff
Oct 13 2025, 9:19 AM
F18753998: D18748.id45001.diff
Oct 4 2025, 9:01 PM
F18684253: D18748.id45000.diff
Sep 26 2025, 9:00 AM
Subscribers
None

Details

Summary

Ref T2543. Fixes two relatively minor things:

  • When builds finish in Harbormaster, send mail "From" the author.
  • Set the firstBroadcast flag so that initial mail picks up earlier history (notably, the "reviewers" line).

For now, I'm not setting firstBroadcast on explicit "Request Review" (but maybe we should), and not trying to deal with weird cases where you leave a bunch of comments on a draft. Those might be fine as-is or may get tweaked later.

Test Plan

Created a revision with Harbormaster builds, ran builds, saw initial email come "From" the right user with more metadata.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionBrowseController.php:1763XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18780
Build 25310: Run Core Tests
Build 25309: arc lint + arc unit