Page MenuHomePhabricator

Attribute revision promotion from "Draft" to "Needs Review" to the author
ClosedPublic

Authored by epriestley on Oct 24 2017, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 4:11 PM
Unknown Object (File)
Sun, Feb 9, 4:09 AM
Unknown Object (File)
Mon, Feb 3, 3:36 AM
Unknown Object (File)
Tue, Jan 28, 7:25 PM
Unknown Object (File)
Jan 22 2025, 5:27 AM
Unknown Object (File)
Jan 21 2025, 9:40 AM
Unknown Object (File)
Jan 1 2025, 8:40 PM
Unknown Object (File)
Dec 8 2024, 5:27 AM
Subscribers
None

Details

Summary

Ref T2543. When Harbormaster finishes builds and promotes a draft revision to review, we currently publish "Harbormaster requested review of...".

Instead, attribute this action to the author, since that's more natural and more useful.

Test Plan

Promoted a diff locally, saw it attributed to me rather than Harbormaster.

Diff Detail

Repository
rP Phabricator
Branch
author1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18740
Build 25250: Run Core Tests
Build 25249: arc lint + arc unit