Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F15452381: D18728.id44957.diff
Sat, Mar 29, 4:19 AM
F15438242: D18728.id44955.diff
Tue, Mar 25, 11:49 PM
F15436879: D18728.id.diff
Tue, Mar 25, 4:42 PM
F15430264: D18728.id.diff
Mon, Mar 24, 6:49 AM
F15425613: D18728.diff
Sun, Mar 23, 5:02 AM
F15381318: D18728.diff
Fri, Mar 14, 7:02 AM
F15376798: D18728.id44957.diff
Thu, Mar 13, 5:39 AM
Unknown Object (File)
Feb 9 2025, 4:13 AM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Branch
dx2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18735
Build 25243: Run Core Tests
Build 25242: arc lint + arc unit

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.