Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F18841003: D18728.diff
Tue, Oct 28, 5:45 AM
F18840652: D18728.diff
Tue, Oct 28, 3:03 AM
F18838979: D18728.id44957.diff
Mon, Oct 27, 1:46 PM
F18836021: D18728.id.diff
Sun, Oct 26, 8:55 PM
F18816894: D18728.diff
Tue, Oct 21, 10:19 AM
F18804591: D18728.id44957.diff
Sat, Oct 18, 10:01 AM
F18735920: D18728.diff
Wed, Oct 1, 4:01 AM
F18716260: D18728.id44955.diff
Mon, Sep 29, 11:39 AM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Branch
dx2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18735
Build 25243: Run Core Tests
Build 25242: arc lint + arc unit

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.