Differential D18695

Add spelling TODOs
ClosedPublic
Actions

Authored by 0 on Oct 9 2017, 6:56 PM.

Tags

None

Referenced Files

	F19523516: D18695.id44883.diff
	Sat, Jan 17, 5:06 PM

	F19523510: D18695.id44883.diff
	Sat, Jan 17, 5:03 PM

	F19523505: D18695.id44883.diff
	Sat, Jan 17, 5:01 PM

	F19523500: D18695.id44883.diff
	Sat, Jan 17, 5:00 PM

	F19523499: D18695.id44883.diff
	Sat, Jan 17, 5:00 PM

	F19520184: D18695.diff
	Fri, Jan 16, 11:44 AM

	F19519702: D18695.diff
	Fri, Jan 16, 7:35 AM

	F19517127: D18695.id.diff
	Thu, Jan 15, 7:57 AM

Subscribers

Restricted Owners Package

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13005: Fix misspelled strings

Commits

rP5897294fa97e: Add spelling TODOs

Summary

Ref T13005. Added reminders not to copy/paste.

Test Plan

None.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/auth/provider/PhabricatorLDAPAuthProvider.php:195	XHP16	TODO Comment
Advice	src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php:6	XHP16	TODO Comment
Advice	src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php:6	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 18661
Build 25137: Run Core Tests
Build 25136: arc lint + arc unit

Event Timeline

0 created this revision.Oct 9 2017, 6:56 PM

Owners added a subscriber: Restricted Owners Package.Oct 9 2017, 6:56 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 9 2017, 6:56 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Oct 9 2017, 6:56 PM

This revision is now accepted and ready to land.Oct 9 2017, 6:56 PM

Closed by commit rP5897294fa97e: Add spelling TODOs (authored by 0, committed by epriestley). · Explain WhyOct 9 2017, 6:56 PM

This revision was automatically updated to reflect the committed changes.

0 mentioned this in D18693: Fix spelling.Oct 9 2017, 6:57 PM

Harbormaster completed remote builds in B18661: Diff 44883.Oct 9 2017, 6:59 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorLDAPAuthProvider.php

1 line

harbormaster/

capability/

HarbormasterBuildPlanDefaultViewCapability.php

1 line

legalpad/

xaction/

LegalpadDocumentPreambleTransaction.php

1 line

Diff 44883

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...

src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php

Loading...

src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php

Loading...