Page MenuHomePhabricator

Add a garbage collector for common ngrams
ClosedPublic

Authored by epriestley on Oct 5 2017, 12:27 AM.
Tags
None
Referenced Files
F15334680: D18687.id44862.diff
Sat, Mar 8, 11:27 AM
F15285783: D18687.id44864.diff
Tue, Mar 4, 4:00 PM
Unknown Object (File)
Sun, Feb 16, 12:07 PM
Unknown Object (File)
Feb 9 2025, 9:09 PM
Unknown Object (File)
Feb 9 2025, 6:51 PM
Unknown Object (File)
Feb 7 2025, 11:09 AM
Unknown Object (File)
Jan 30 2025, 3:19 AM
Unknown Object (File)
Jan 22 2025, 4:17 PM
Subscribers
None

Details

Summary

Ref T13000. After an ngram is marked as "common", we can delete it from the storage table.

Currently, the only way to get ngrams marked as "common" is to manually run bin/search ngrams, so this has no impact on normal installs.

Test Plan

Ran bin/garbage collect, saw it start chewing through my local Maniphest ngrams table and removing common ngrams.

Diff Detail

Repository
rP Phabricator
Branch
garbage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18641
Build 25113: Run Core Tests
Build 25112: arc lint + arc unit

Event Timeline

  • Also add a little warning text to bin/search ngrams.
This revision is now accepted and ready to land.Oct 5 2017, 6:01 PM
This revision was automatically updated to reflect the committed changes.