Page MenuHomePhabricator

Add a "Draft" state for revisions, and action bucket support
ClosedPublic

Authored by epriestley on Sep 18 2017, 7:57 PM.
Tags
None
Referenced Files
F15283917: D18625.diff
Tue, Mar 4, 8:51 AM
F15282943: D18625.diff
Tue, Mar 4, 3:49 AM
Unknown Object (File)
Fri, Feb 21, 2:59 AM
Unknown Object (File)
Feb 2 2025, 3:51 AM
Unknown Object (File)
Jan 21 2025, 10:36 AM
Unknown Object (File)
Jan 17 2025, 2:02 PM
Unknown Object (File)
Jan 12 2025, 1:08 PM
Unknown Object (File)
Jan 6 2025, 8:54 PM
Subscribers
None

Details

Summary

Ref T2543. There's no way to put revisions into this state yet, but start adding support for when there is.

Adds the status constant, plus support for bucketing them.

Test Plan
  • Manually put a revision in "Draft" state by updating the database directly.
  • Verified my drafts showed up in a "Drafts" section on the bucket view.
  • Verified others' drafts did not appear on the action bucket view.
  • Viewed revisions, queried for "Draft" revisions, etc (stuff we get for free).

Screen Shot 2017-09-18 at 12.56.40 PM.png (132×274 px, 14 KB)

Screen Shot 2017-09-18 at 12.54.05 PM.png (235×284 px, 21 KB)

Screen Shot 2017-09-18 at 12.54.00 PM.png (236×396 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18492
Build 24902: Run Core Tests
Build 24901: arc lint + arc unit