Page MenuHomePhabricator

Add explicit limits to unit test/lint error names
ClosedPublic

Authored by amckinley on Sep 14 2017, 6:28 PM.
Tags
None
Referenced Files
F15460151: D18603.id.diff
Mon, Mar 31, 8:43 PM
F15458259: D18603.diff
Sun, Mar 30, 10:16 PM
F15432933: D18603.id.diff
Mon, Mar 24, 8:21 PM
F15424079: D18603.id44668.diff
Sat, Mar 22, 8:05 PM
F15402815: D18603.id44668.diff
Tue, Mar 18, 12:30 AM
F15337731: D18603.diff
Sun, Mar 9, 7:22 AM
F15332710: D18603.id44668.diff
Fri, Mar 7, 7:26 PM
Unknown Object (File)
Feb 28 2025, 5:10 AM
Subscribers

Details

Summary

Fixes T12981.

See new arc lint output: P2071

See new arc unit output: P2072

Test Plan

Ran arc unit/lint/diff and observed new error instead of a Conduit error

Diff Detail

Repository
rARC Arcanist
Branch
T12981
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18449
Build 24843: Run Core Tests
Build 24842: arc lint + arc unit

Event Timeline

Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 14 2017, 6:39 PM

Do you still want me to add the same checks to HarbormasterBuildUnitMessage->newFromDictionary()? AFAICT, that would just move the error message from save time to creation time.

This revision was automatically updated to reflect the committed changes.

Also, I landed this onto experimental. Do we want this on master as well? If so, what's the best way to accomplish that? arc land --revision D18603 --onto master?

newFromDictionary() gets called before saving the records in the database (JSON is converted to objects with newFromDictionary(), then saved). It's maybe worth doing since it'll be a slightly nicer experience for old arc clients or manual Conduit callers, but not a big deal either way.

Easiest is probably git cherry-pick <commit> + git push, land doesn't know that you want to cherry-pick instead of rebase/merge.