Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F17840737: D18598.diff
Sat, Jul 26, 9:30 PM
F17840030: D18598.diff
Sat, Jul 26, 8:40 PM
F17833770: D18598.id44657.diff
Sat, Jul 26, 1:49 PM
F17828376: D18598.id44656.diff
Sat, Jul 26, 9:07 AM
F17828342: D18598.id.diff
Sat, Jul 26, 9:06 AM
F17806958: D18598.id44662.diff
Fri, Jul 25, 2:24 PM
F17765650: D18598.id44657.diff
Wed, Jul 23, 2:14 AM
F17753854: D18598.id44662.diff
Tue, Jul 22, 9:44 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Branch
bytelimit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18437
Build 24825: Run Core Tests
Build 24824: arc lint + arc unit