Page MenuHomePhabricator

Automatically archive old Differential hunks into file storage
AbandonedPublic

Authored by epriestley on Sep 11 2017, 3:51 PM.
Tags
None
Referenced Files
F13228532: D18585.id.diff
Mon, May 20, 10:13 AM
F13219101: D18585.id.diff
Sat, May 18, 3:20 PM
F13203972: D18585.diff
Wed, May 15, 12:15 AM
F13202090: D18585.diff
Tue, May 14, 9:38 PM
F13186662: D18585.diff
Sat, May 11, 3:48 AM
Unknown Object (File)
Tue, May 7, 7:06 AM
Unknown Object (File)
Fri, May 3, 5:22 AM
Unknown Object (File)
Fri, May 3, 5:10 AM
Subscribers
None

Details

Summary

Ref T12932. Once a hunk is more than 30 days old, move it to file storage for long-term archiving. This implies a very small performance cost, but makes maintenance and backups easier, especially if files mostly end up in a storage service like S3.

Test Plan

Ran the GC, looked at the database, saw most hunks move to Files. Browsed a lot of older revisions, saw all the data.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18412
Build 24790: Run Core Tests
Build 24789: arc lint + arc unit

Event Timeline

Actually, I'm not sure about pursuing this. Let me follow up on T12932. I think D18584 is fine whether we move this forward or not, since it generally improves some other things.