Page MenuHomePhabricator

Automatically archive old Differential hunks into file storage
AbandonedPublic

Authored by epriestley on Sep 11 2017, 3:51 PM.
Tags
None
Referenced Files
F13141925: D18585.diff
Fri, May 3, 5:22 AM
F13141764: D18585.diff
Fri, May 3, 5:10 AM
F13136733: D18585.diff
Thu, May 2, 3:24 PM
Unknown Object (File)
Thu, Apr 25, 12:47 AM
Unknown Object (File)
Fri, Apr 19, 2:41 AM
Unknown Object (File)
Sat, Apr 6, 7:48 AM
Unknown Object (File)
Mar 5 2024, 4:09 AM
Unknown Object (File)
Feb 25 2024, 11:25 AM
Subscribers
None

Details

Summary

Ref T12932. Once a hunk is more than 30 days old, move it to file storage for long-term archiving. This implies a very small performance cost, but makes maintenance and backups easier, especially if files mostly end up in a storage service like S3.

Test Plan

Ran the GC, looked at the database, saw most hunks move to Files. Browsed a lot of older revisions, saw all the data.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18412
Build 24790: Run Core Tests
Build 24789: arc lint + arc unit

Event Timeline

Actually, I'm not sure about pursuing this. Let me follow up on T12932. I think D18584 is fine whether we move this forward or not, since it generally improves some other things.