Paths

Table of Contentst

Differential D18576

Correct `bin/storage analyze` internal API for cluster environments
ClosedPublic
Actions

Authored by epriestley on Sep 7 2017, 11:31 PM.

Details

Reviewers

chad

Maniphest Tasks

T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size

Commits

rP4cae4a3b767f: Correct `bin/storage analyze` internal API for cluster environments

Summary

Ref T12819. This worked right in a non-cluster environment, but bin/storage upgrade iterates over each master in a partitioned cluster environment.

Tweak the API so bin/storage analyze targets a single host but bin/storage upgrade can hit all the masters.

Test Plan

Will run bin/storage upgrade in production again. Ran upgrade and analyze locally, still work fine.

Diff Detail

Repository

rP Phabricator

Branch

analyze2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18391
Build 24763: Run Core Tests
Build 24762: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 7 2017, 11:31 PM

Harbormaster completed remote builds in B18391: Diff 44608.Sep 7 2017, 11:32 PM

chad accepted this revision.Sep 7 2017, 11:34 PM

This revision is now accepted and ready to land.Sep 7 2017, 11:34 PM

Closed by commit rP4cae4a3b767f: Correct `bin/storage analyze` internal API for cluster environments (authored by epriestley). · Explain WhySep 7 2017, 11:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementAnalyzeWorkflow.php

3 lines

PhabricatorStorageManagementWorkflow.php

7 lines

Diff 44608

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAnalyzeWorkflow.php