Page MenuHomePhabricator
Differential D18576

Correct `bin/storage analyze` internal API for cluster environments
ClosedPublic
Actions

Authored by epriestley on Sep 7 2017, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:44 PM
Unknown Object (File)
Tue, Apr 23, 10:50 AM
Unknown Object (File)
Sun, Apr 21, 4:28 PM
Unknown Object (File)
Fri, Apr 19, 2:41 AM
Unknown Object (File)
Fri, Apr 19, 2:41 AM
Unknown Object (File)
Fri, Apr 19, 2:41 AM
Unknown Object (File)
Tue, Apr 16, 5:56 PM
Unknown Object (File)
Sun, Apr 14, 10:19 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size
Commits
rP4cae4a3b767f: Correct `bin/storage analyze` internal API for cluster environments
Summary

Ref T12819. This worked right in a non-cluster environment, but bin/storage upgrade iterates over each master in a partitioned cluster environment.

Tweak the API so bin/storage analyze targets a single host but bin/storage upgrade can hit all the masters.

Test Plan

Will run bin/storage upgrade in production again. Ran upgrade and analyze locally, still work fine.

Diff Detail

Repository
rP Phabricator
Branch
analyze2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18391
Build 24763: Run Core Tests
Build 24762: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
workflow/
3 lines
7 lines

Diff 44608

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAnalyzeWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility