Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F13134944: D18534.id44513.diff
Thu, May 2, 6:03 AM
Unknown Object (File)
Wed, May 1, 12:21 AM
Unknown Object (File)
Sat, Apr 27, 11:03 PM
Unknown Object (File)
Thu, Apr 25, 3:41 AM
Unknown Object (File)
Sat, Apr 20, 12:44 PM
Unknown Object (File)
Fri, Apr 19, 6:48 PM
Unknown Object (File)
Thu, Apr 11, 10:50 AM
Unknown Object (File)
Mar 28 2024, 9:44 PM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Branch
ferret2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18284
Build 24603: Run Core Tests
Build 24602: arc lint + arc unit