Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 24 2026, 2:42 PM
Unknown Object (File)
Aug 17 2026, 6:00 AM
Unknown Object (File)
Aug 7 2026, 12:02 PM
Unknown Object (File)
Aug 5 2026, 5:06 PM
Unknown Object (File)
Aug 4 2026, 4:03 PM
Unknown Object (File)
Jul 5 2026, 7:41 AM
Unknown Object (File)
Jul 2 2026, 10:12 AM
Unknown Object (File)
Jul 2 2026, 10:07 AM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Branch
ferret2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18284
Build 24603: Run Core Tests
Build 24602: arc lint + arc unit