Page MenuHomePhabricator

Consolidate more Ferret engine code into FerretEngine
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:30 PM.
Tags
None
Referenced Files
F15459977: D18533.id44499.diff
Mon, Mar 31, 6:49 PM
F15453770: D18533.id44512.diff
Sat, Mar 29, 2:14 PM
F15443340: D18533.diff
Thu, Mar 27, 3:51 AM
F15438454: D18533.id.diff
Wed, Mar 26, 12:46 AM
F15433101: D18533.diff
Mon, Mar 24, 9:23 PM
F15422408: D18533.id44512.diff
Sat, Mar 22, 8:03 AM
Unknown Object (File)
Feb 22 2025, 9:49 AM
Unknown Object (File)
Feb 9 2025, 9:34 PM
Subscribers
None

Details

Summary

Ref T12819. Earlier I separated some ngram code into an "ngram engine" hoping to share it across the simple Ngrams stuff and the full Ferret stuff, but they actually use slightly different rules. Just pull more of this stuff into FerretEngine to reduce the number of moving pieces and the amount of code duplication.

Test Plan

Searched for terms, rebuilt indexes.

Diff Detail

Repository
rP Phabricator
Branch
ferret1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18283
Build 24601: Run Core Tests
Build 24600: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.