Page MenuHomePhabricator

Consolidate more Ferret engine code into FerretEngine
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:39 AM
Unknown Object (File)
Fri, Apr 19, 6:47 PM
Unknown Object (File)
Mon, Apr 15, 9:27 PM
Unknown Object (File)
Fri, Mar 29, 5:31 AM
Unknown Object (File)
Thu, Mar 28, 11:32 PM
Unknown Object (File)
Thu, Mar 28, 4:04 AM
Unknown Object (File)
Mar 27 2024, 12:13 AM
Unknown Object (File)
Mar 20 2024, 6:31 AM
Subscribers
None

Details

Summary

Ref T12819. Earlier I separated some ngram code into an "ngram engine" hoping to share it across the simple Ngrams stuff and the full Ferret stuff, but they actually use slightly different rules. Just pull more of this stuff into FerretEngine to reduce the number of moving pieces and the amount of code duplication.

Test Plan

Searched for terms, rebuilt indexes.

Diff Detail

Repository
rP Phabricator
Branch
ferret1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18283
Build 24601: Run Core Tests
Build 24600: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.