Paths

Table of Contentst

Cheat our way through `arc version` on Windows for the moment
ClosedPublic
Actions

Authored by epriestley on Sep 2 2017, 1:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 4, 8:32 AM

	Unknown Object (File)
	Thu, Jan 30, 11:43 PM

	Unknown Object (File)
	Thu, Jan 23, 3:52 PM

	Unknown Object (File)
	Wed, Jan 15, 3:33 PM

	Unknown Object (File)
	Mon, Jan 13, 5:21 PM

	Unknown Object (File)
	Dec 30 2024, 6:45 AM

	Unknown Object (File)
	Dec 17 2024, 4:36 AM

	Unknown Object (File)
	Dec 8 2024, 9:18 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8291: arc version fails on Windows

Commits

rARCd9cb5b18fbc1: Cheat our way through `arc version` on Windows for the moment

Summary

Fixes T8291. See PHI52. This is papering over the real issue (T8298) but it's a 10-second patch so just improve things slightly for now.

Test Plan

Ran arc version locally; patch confirmed on a Windows system by an affected user.

Diff Detail

Repository

rARC Arcanist

Branch

version1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18261
Build 24559: Run Core Tests
Build 24558: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 2 2017, 1:04 AM

Harbormaster completed remote builds in B18261: Diff 44477.Sep 2 2017, 1:05 AM

chad accepted this revision.Sep 2 2017, 1:05 AM

This revision is now accepted and ready to land.Sep 2 2017, 1:05 AM

Closed by commit rARCd9cb5b18fbc1: Cheat our way through `arc version` on Windows for the moment (authored by epriestley). · Explain WhySep 2 2017, 1:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistVersionWorkflow.php

10 lines

Diff 44477

View Options

src/workflow/ArcanistVersionWorkflow.php

Cheat our way through `arc version` on Windows for the momentClosedPublicActions