Page MenuHomePhabricator

Separate fulltext engine extensions into "enrich" and "index" phases
ClosedPublic

Authored by epriestley on Sep 1 2017, 4:22 PM.
Tags
None
Referenced Files
F13216132: D18513.id44467.diff
Fri, May 17, 10:31 PM
F13205691: D18513.diff
Wed, May 15, 2:17 AM
F13189377: D18513.diff
Sat, May 11, 5:54 AM
Unknown Object (File)
Tue, May 7, 9:44 AM
Unknown Object (File)
Fri, May 3, 9:40 AM
Unknown Object (File)
Thu, May 2, 2:44 PM
Unknown Object (File)
Sun, Apr 28, 5:17 PM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Subscribers
None
Tokens
"Like" token, awarded by 20after4.

Details

Summary

Ref T12819. Some of the extensions "enrich" the document (adding more fields or relationships), while others "index" it (insert it into some kind of index for later searching).

Currently, these are all muddled under a single "index" phase. However, the Ferret extension cares about fields and relationships which other extensions may add.

Split this into two phases: "enrich" adds fields and relationships so other extensions can read them later if they want. "Index" happens after the document is built and has all the fields and relationships.

The specific problem this solves is that comments may not have been added to the document when the Ferret extension runs. By moving them to the "enrich" phase, the Ferret engine will be able to see and index comments.

Test Plan

Ran bin/search index ..., grepped for indexFulltextDocument.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 1 2017, 4:27 PM
This revision was automatically updated to reflect the committed changes.