Page MenuHomePhabricator

Separate fulltext engine extensions into "enrich" and "index" phases
ClosedPublic

Authored by epriestley on Sep 1 2017, 4:22 PM.
Tags
None
Referenced Files
F14058995: D18513.diff
Sun, Nov 17, 4:39 PM
F14045985: D18513.diff
Wed, Nov 13, 4:56 PM
F14035697: D18513.diff
Sun, Nov 10, 7:12 AM
F14030803: D18513.diff
Sat, Nov 9, 6:51 AM
F14030754: D18513.diff
Sat, Nov 9, 6:16 AM
F14021352: D18513.diff
Wed, Nov 6, 7:58 AM
F14012801: D18513.id44467.diff
Fri, Nov 1, 7:24 PM
F14006925: D18513.diff
Mon, Oct 28, 9:27 PM
Subscribers
None
Tokens
"Like" token, awarded by 20after4.

Details

Summary

Ref T12819. Some of the extensions "enrich" the document (adding more fields or relationships), while others "index" it (insert it into some kind of index for later searching).

Currently, these are all muddled under a single "index" phase. However, the Ferret extension cares about fields and relationships which other extensions may add.

Split this into two phases: "enrich" adds fields and relationships so other extensions can read them later if they want. "Index" happens after the document is built and has all the fields and relationships.

The specific problem this solves is that comments may not have been added to the document when the Ferret extension runs. By moving them to the "enrich" phase, the Ferret engine will be able to see and index comments.

Test Plan

Ran bin/search index ..., grepped for indexFulltextDocument.

Diff Detail

Repository
rP Phabricator
Branch
index1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18251
Build 24547: Run Core Tests
Build 24546: arc lint + arc unit

Event Timeline

chad edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 1 2017, 4:27 PM
This revision was automatically updated to reflect the committed changes.