Restore ANSI highlighting of lint sections to lint output
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 8:06 PM.

Details

Reviewers

Maniphest Tasks

T9846: Diff on `arc lint` misleading when the replacement has newlines

Commits

rARC17515c94b2da: (stable) Promote 2017 Week 35
rARCad8214456add: Restore ANSI highlighting of lint sections to lint output

Summary

Fixes T9846. This restores the last missing feature, ANSI highlighting of diff sections.

Test Plan

Added a mode so we can actually test this stuff, activated that mode, wrote unit tests.

Did a bunch of actual lint locally too and looked at it, all seemed sane.

Diff Detail

Repository

rARC Arcanist

Branch

ldisplay5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18245
Build 24540: Run Core Tests
Build 24539: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 31 2017, 8:06 PM

Harbormaster completed remote builds in B18245: Diff 44461.Aug 31 2017, 8:06 PM

Harbormaster completed remote builds in B18245: Diff 44461.

chad accepted this revision.Aug 31 2017, 8:20 PM

This revision is now accepted and ready to land.Aug 31 2017, 8:20 PM

Closed by commit rARCad8214456add: Restore ANSI highlighting of lint sections to lint output (authored by epriestley). · Explain WhyAug 31 2017, 8:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistConsoleLintRenderer.php

50 lines

__tests__/

ArcanistConsoleLintRendererTestCase.php

9 lines

data/

inline.expect

4 lines

	original.expect
	overlap.expect

3 lines

original.txt

1 line

overlap.expect

4 lines

simple.expect

4 lines

Diff 44461

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/inline.expect

View Options

src/lint/renderer/tests/data/original.expect

View Options

src/lint/renderer/tests/data/original.txt

View Options

src/lint/renderer/tests/data/overlap.expect

View Options

src/lint/renderer/tests/data/simple.expect

Restore ANSI highlighting of lint sections to lint outputClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44461

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/inline.expect

src/lint/renderer/__tests__/data/original.expect

src/lint/renderer/__tests__/data/original.txt

src/lint/renderer/__tests__/data/overlap.expect

src/lint/renderer/__tests__/data/simple.expect

Restore ANSI highlighting of lint sections to lint output
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/inline.expect

src/lint/renderer/tests/data/original.expect

src/lint/renderer/tests/data/original.txt

src/lint/renderer/tests/data/overlap.expect

src/lint/renderer/tests/data/simple.expect