Clarify language when Autoclose is disabled for a repository
ClosedPublic
Actions

Authored by chad on Aug 28 2017, 6:43 PM.

Tags

None

Referenced Files

	F15451369: D18482.id44399.diff
	Fri, Mar 28, 9:44 PM

	F15448922: D18482.id44400.diff
	Fri, Mar 28, 7:41 AM

	F15444677: D18482.id.diff
	Thu, Mar 27, 10:41 AM

	F15440443: D18482.diff
	Wed, Mar 26, 12:52 PM

	F15404699: D18482.id44399.diff
	Tue, Mar 18, 8:41 AM

	F15404284: D18482.id44400.diff
	Tue, Mar 18, 7:06 AM

	Unknown Object (File)
	Feb 26 2025, 4:33 AM

	Unknown Object (File)
	Feb 24 2025, 12:29 PM

View All Files

Subscribers

Korvin

Tokens

"Party Time" token, awarded by allixsenos.

Details

Reviewers

epriestley

Maniphest Tasks

T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting."

Commits

rPb8b701faf734: Clarify language when Autoclose is disabled for a repository

Summary

Fixes T12051, adds additional language.

Test Plan

Disable Autoclose in Actions, see updated language under Branches.

Diff Detail

Repository

rP Phabricator

Branch

autoclose (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18186
Build 24451: Run Core Tests
Build 24450: arc lint + arc unit

Event Timeline

chad created this revision.Aug 28 2017, 6:43 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 28 2017, 6:43 PM

chad edited the test plan for this revision. (Show Details)Aug 28 2017, 6:44 PM

Harbormaster completed remote builds in B18186: Diff 44399.Aug 28 2017, 6:45 PM

Also fine with not doing this, since no other user has encountered this issue.

This revision is now accepted and ready to land.Aug 28 2017, 6:59 PM

No I want the leaderboard karma.

Closed by commit rPb8b701faf734: Clarify language when Autoclose is disabled for a repository (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 28 2017, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Hall of Heroes here I come.

allixsenos awarded a token.Aug 31 2017, 12:51 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

management/

DiffusionRepositoryBranchesManagementPanel.php

13 lines

Diff 44399

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Clarify language when Autoclose is disabled for a repositoryClosedPublicActions