Page MenuHomePhabricator

Fix bad tables in diffusion blame
ClosedPublic

Authored by chad on Aug 25 2017, 2:53 AM.
Tags
None
Referenced Files
F15278459: D18474.id44382.diff
Sun, Mar 2, 8:52 PM
Unknown Object (File)
Sat, Mar 1, 7:22 PM
Unknown Object (File)
Fri, Feb 21, 3:21 AM
Unknown Object (File)
Sun, Feb 9, 4:38 AM
Unknown Object (File)
Sun, Feb 9, 4:38 AM
Unknown Object (File)
Sun, Feb 9, 4:38 AM
Unknown Object (File)
Sun, Feb 9, 4:38 AM
Unknown Object (File)
Mon, Feb 3, 6:49 PM
Subscribers

Details

Summary

My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have any revisions at all, then always show the column, with or without a link inside.

Test Plan

going on a limb this is the correct fix and test on secure... again ...

Diff Detail

Repository
rP Phabricator
Branch
blame-fix-fix (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18168
Build 24422: Run Core Tests
Build 24421: arc lint + arc unit