Page MenuHomePhabricator

Fix bad tables in diffusion blame
ClosedPublic

Authored by chad on Aug 25 2017, 2:53 AM.
Tags
None
Referenced Files
F15465517: D18474.id44382.diff
Wed, Apr 2, 7:49 PM
F15462228: D18474.id44381.diff
Tue, Apr 1, 1:12 PM
F15458996: D18474.id.diff
Mon, Mar 31, 9:00 AM
F15457258: D18474.diff
Sun, Mar 30, 3:17 PM
F15436712: D18474.id44382.diff
Tue, Mar 25, 4:09 PM
F15379738: D18474.diff
Thu, Mar 13, 11:07 PM
F15311256: D18474.id44382.diff
Mar 6 2025, 9:55 AM
Unknown Object (File)
Mar 2 2025, 8:52 PM
Subscribers

Details

Summary

My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have any revisions at all, then always show the column, with or without a link inside.

Test Plan

going on a limb this is the correct fix and test on secure... again ...

Diff Detail

Repository
rP Phabricator
Branch
blame-fix-fix (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18168
Build 24422: Run Core Tests
Build 24421: arc lint + arc unit