Page MenuHomePhabricator

Fix bad tables in diffusion blame
ClosedPublic

Authored by chad on Aug 25 2017, 2:53 AM.
Tags
None
Referenced Files
F14041958: D18474.id44382.diff
Mon, Nov 11, 11:12 PM
F13983566: D18474.id.diff
Sun, Oct 20, 7:19 AM
F13983482: D18474.diff
Sun, Oct 20, 6:46 AM
Unknown Object (File)
Oct 1 2024, 8:13 AM
Unknown Object (File)
Sep 29 2024, 7:34 AM
Unknown Object (File)
Sep 25 2024, 9:28 AM
Unknown Object (File)
Sep 20 2024, 12:20 PM
Unknown Object (File)
Sep 20 2024, 10:13 AM
Subscribers

Details

Summary

My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have any revisions at all, then always show the column, with or without a link inside.

Test Plan

going on a limb this is the correct fix and test on secure... again ...

Diff Detail

Repository
rP Phabricator
Branch
blame-fix-fix (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18168
Build 24422: Run Core Tests
Build 24421: arc lint + arc unit