Page MenuHomePhabricator

Fix bad tables in diffusion blame
ClosedPublic

Authored by chad on Aug 25 2017, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 9:28 AM
Unknown Object (File)
Fri, Sep 20, 12:20 PM
Unknown Object (File)
Fri, Sep 20, 10:13 AM
Unknown Object (File)
Fri, Sep 6, 12:58 AM
Unknown Object (File)
Aug 27 2024, 5:26 PM
Unknown Object (File)
Aug 25 2024, 12:21 PM
Unknown Object (File)
Aug 18 2024, 3:17 PM
Unknown Object (File)
Aug 17 2024, 5:16 PM
Subscribers

Details

Summary

My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have any revisions at all, then always show the column, with or without a link inside.

Test Plan

going on a limb this is the correct fix and test on secure... again ...

Diff Detail

Repository
rP Phabricator
Branch
blame-fix-fix (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18168
Build 24422: Run Core Tests
Build 24421: arc lint + arc unit