Dont send an email when someone views a Phame post
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 1:54 AM.

Tags

None

Referenced Files

	F19891412: D18471.diff
	Fri, Mar 27, 6:33 AM

	F19860526: D18471.diff
	Mar 14 2026, 7:17 AM

	F19855055: D18471.id44375.diff
	Mar 13 2026, 12:18 PM

	F19804905: D18471.diff
	Mar 2 2026, 2:44 PM

	F19511345: D18471.id.diff
	Jan 12 2026, 1:00 AM

	F19472048: D18471.id44375.diff
	Jan 6 2026, 10:25 PM

	F19385886: D18471.diff
	Dec 27 2025, 2:45 AM

	F19254549: D18471.id.diff
	Dec 22 2025, 11:40 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
avivey

Commits

rP336fe5cdc525: Dont send an email when someone views a Phame post

Summary

lulz. :(

Test Plan

Load PhamePost, get email. Fix. Reload PhamePost, no email.

Diff Detail

Repository

rP Phabricator

Branch

phame-email (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18162
Build 24413: Run Core Tests
Build 24412: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 1:54 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 1:54 AM

Harbormaster completed remote builds in B18162: Diff 44375.Aug 25 2017, 1:55 AM

chad added a reviewer: avivey.Aug 25 2017, 1:56 AM

I'm assuming this is called for each xaction type?

This revision is now accepted and ready to land.Aug 25 2017, 1:57 AM

It's straight copy/pasta from shouldPublishFeed

Closed by commit rP336fe5cdc525: Dont send an email when someone views a Phame post (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 2:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

editor/

PhamePostEditor.php

6 lines

Diff 44375

View Options

src/applications/phame/editor/PhamePostEditor.php

Dont send an email when someone views a Phame postClosedPublicActions