Dont send an email when someone views a Phame post
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 1:54 AM.

Tags

None

Referenced Files

	F15180520: D18471.id44375.diff
	Wed, Feb 19, 8:44 PM

	Unknown Object (File)
	Mon, Feb 17, 1:43 AM

	Unknown Object (File)
	Sat, Feb 15, 5:30 AM

	Unknown Object (File)
	Thu, Feb 13, 6:25 PM

	Unknown Object (File)
	Sun, Feb 9, 4:38 AM

	Unknown Object (File)
	Sun, Feb 9, 4:38 AM

	Unknown Object (File)
	Sun, Feb 9, 4:38 AM

	Unknown Object (File)
	Sun, Feb 9, 4:38 AM

View All 88 Files

Subscribers

Korvin

Details

Reviewers

epriestley
avivey

Commits

rP336fe5cdc525: Dont send an email when someone views a Phame post

Summary

lulz. :(

Test Plan

Load PhamePost, get email. Fix. Reload PhamePost, no email.

Diff Detail

Repository

rP Phabricator

Branch

phame-email (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18162
Build 24413: Run Core Tests
Build 24412: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 1:54 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 1:54 AM

Harbormaster completed remote builds in B18162: Diff 44375.Aug 25 2017, 1:55 AM

chad added a reviewer: avivey.Aug 25 2017, 1:56 AM

I'm assuming this is called for each xaction type?

This revision is now accepted and ready to land.Aug 25 2017, 1:57 AM

It's straight copy/pasta from shouldPublishFeed

Closed by commit rP336fe5cdc525: Dont send an email when someone views a Phame post (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 2:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

editor/

PhamePostEditor.php

6 lines

Diff 44375

View Options

src/applications/phame/editor/PhamePostEditor.php

Dont send an email when someone views a Phame postClosedPublicActions