Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F15484263: D18468.diff
Wed, Apr 9, 5:18 PM
F15426766: D18468.diff
Sun, Mar 23, 10:45 AM
F15411097: D18468.diff
Mar 19 2025, 8:49 AM
F15410089: D18468.diff
Mar 19 2025, 6:46 AM
F15381314: D18468.id44363.diff
Mar 14 2025, 7:01 AM
F15379102: D18468.id44371.diff
Mar 13 2025, 6:42 PM
Unknown Object (File)
Feb 9 2025, 4:38 AM
Unknown Object (File)
Feb 9 2025, 4:38 AM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable