Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F13283285: D18468.diff
Sun, Jun 2, 1:43 PM
F13272457: D18468.diff
Thu, May 30, 2:13 PM
F13210090: D18468.id44371.diff
Fri, May 17, 3:55 AM
F13208527: D18468.diff
Thu, May 16, 4:51 PM
F13193642: D18468.diff
Sun, May 12, 4:16 PM
F13176759: D18468.diff
Wed, May 8, 4:53 PM
Unknown Object (File)
Sat, May 4, 5:12 PM
Unknown Object (File)
May 2 2024, 6:54 PM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Branch
xaction3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18150
Build 24398: Run Core Tests
Build 24397: arc lint + arc unit