Page MenuHomePhabricator

Slightly simplify logic for determining if an inline comment has an effect
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:16 PM.
Tags
None
Referenced Files
F19304353: D18468.id.diff
Dec 24 2025, 9:51 AM
F19291970: D18468.diff
Dec 23 2025, 9:21 AM
F18995673: D18468.id44363.diff
Nov 19 2025, 9:24 PM
F18855419: D18468.id44363.diff
Nov 1 2025, 5:16 AM
F18621614: D18468.diff
Sep 15 2025, 8:57 AM
F18086668: D18468.diff
Aug 5 2025, 11:16 PM
F17925002: D18468.id44371.diff
Jul 30 2025, 10:50 AM
F17755079: D18468.id44363.diff
Jul 22 2025, 11:52 AM
Subscribers
None

Details

Summary

Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan

Made inlines, tried to submit empty comments. Behavior unchanged.

Diff Detail

Repository
rP Phabricator
Branch
xaction3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18150
Build 24398: Run Core Tests
Build 24397: arc lint + arc unit