Differential D18452

Update blame view in Diffusion
ClosedPublic
Actions

Authored by chad on Aug 22 2017, 4:13 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12824: Redesign Diffusion

Commits

rPac91ab1ef919: Update blame view in Diffusion

Summary

Ref T12824, adds more information to the blame view, exposes date, commit summary, lighter colors.

Test Plan

Review many diffs with and without blame on.

Screen Shot 2017-08-21 at 9.07.23 PM.png (2×2 px, 791 KB)

Screen Shot 2017-08-21 at 9.07.31 PM.png (2×2 px, 709 KB)

Diff Detail

Repository

rP Phabricator

Branch

blame-colors (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18122
Build 24355: Run Core Tests
Build 24354: arc lint + arc unit

Event Timeline

chad created this revision.Aug 22 2017, 4:13 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 22 2017, 4:13 AM

Harbormaster completed remote builds in B18120: Diff 44330.Aug 22 2017, 4:14 AM

chad edited the test plan for this revision. (Show Details)Aug 22 2017, 4:15 AM

unneeded changes

Harbormaster completed remote builds in B18122: Diff 44333.Aug 23 2017, 3:47 PM

epriestley accepted this revision.Aug 23 2017, 4:29 PM

This revision is now accepted and ready to land.Aug 23 2017, 4:29 PM

Closed by commit rPac91ab1ef919: Update blame view in Diffusion (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 23 2017, 4:47 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18746: Revert changes to Diffusion blame view.Oct 31 2017, 6:04 PM

epriestley mentioned this in rP90d0f8ac6cf5: Revert changes to Diffusion blame view.Oct 31 2017, 6:54 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

90 lines

webroot/

rsrc/

css/

application/

diffusion/

diffusion-source.css

61 lines

Diff 44333

View Options

resources/celerity/map.php

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

View Options

webroot/rsrc/css/application/diffusion/diffusion-source.css

Update blame view in DiffusionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44333

resources/celerity/map.php

src/applications/diffusion/controller/DiffusionBrowseController.php

webroot/rsrc/css/application/diffusion/diffusion-source.css

Update blame view in Diffusion
ClosedPublic
Actions

Revision Contents
Changeset List