Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
F19923442: D18442.id44309.diff
Tue, Apr 7, 3:06 AM
F19912599: D18442.id44308.diff
Thu, Apr 2, 8:17 PM
F19280405: D18442.id44309.diff
Dec 23 2025, 3:08 AM
F19236707: D18442.diff
Dec 21 2025, 7:26 PM
F19133035: D18442.id44308.diff
Dec 10 2025, 6:26 AM
F19080057: D18442.id44308.diff
Dec 1 2025, 11:55 PM
F18852299: D18442.id44309.diff
Oct 31 2025, 7:53 AM
F18811655: D18442.diff
Oct 20 2025, 4:09 AM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Branch
setup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18099
Build 24321: Run Core Tests
Build 24320: arc lint + arc unit