Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:35 AM
Unknown Object (File)
Sun, Feb 9, 4:35 AM
Unknown Object (File)
Sun, Feb 9, 4:35 AM
Unknown Object (File)
Sun, Feb 9, 4:35 AM
Unknown Object (File)
Wed, Jan 29, 1:27 PM
Unknown Object (File)
Mon, Jan 27, 2:36 AM
Unknown Object (File)
Fri, Jan 24, 10:15 PM
Unknown Object (File)
Fri, Jan 24, 10:14 PM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Branch
setup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18099
Build 24321: Run Core Tests
Build 24320: arc lint + arc unit