Page MenuHomePhabricator

Make the default ApplicationSearch query explicit, not just the first item in the list
ClosedPublic

Authored by epriestley on Aug 14 2017, 6:13 PM.
Tags
None
Referenced Files
F13170299: D18422.diff
Tue, May 7, 9:18 AM
Unknown Object (File)
Mon, May 6, 6:50 AM
Unknown Object (File)
Sat, May 4, 4:14 PM
Unknown Object (File)
Sat, May 4, 2:38 PM
Unknown Object (File)
Mon, Apr 29, 9:48 PM
Unknown Object (File)
Sun, Apr 28, 6:23 AM
Unknown Object (File)
Sun, Apr 28, 2:42 AM
Unknown Object (File)
Sat, Apr 27, 6:15 AM
Subscribers
None

Details

Summary

Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan
  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

Screen Shot 2017-08-14 at 11.05.40 AM.png (1×1 px, 154 KB)

Diff Detail

Repository
rP Phabricator
Branch
item2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18059
Build 24258: Run Core Tests
Build 24257: arc lint + arc unit