Page MenuHomePhabricator

Make the default ApplicationSearch query explicit, not just the first item in the list
ClosedPublic

Authored by epriestley on Aug 14 2017, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 3:43 PM
Unknown Object (File)
Feb 15 2024, 2:04 PM
Unknown Object (File)
Jan 25 2024, 7:31 AM
Unknown Object (File)
Dec 27 2023, 11:53 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 21 2023, 8:37 PM
Subscribers
None

Details

Summary

Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan
  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

Screen Shot 2017-08-14 at 11.05.40 AM.png (1×1 px, 154 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable