Fix an inverted condition for the "Reopen Revision" action
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rPea4e33261e49: (stable) Fix an inverted condition for the "Reopen Revision" action
rPef8d4e2126af: Fix an inverted condition for the "Reopen Revision" action

Summary

Ref T2543. I converted this condition the wrong way, missing a !. I'll cherry-pick this to stable.

Test Plan

No more "Reopen Revision" action available on open revisions.

Diff Detail

Repository

rP Phabricator

Branch

status8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18012
Build 24195: Run Core Tests
Build 24194: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 4:48 PM

Harbormaster completed remote builds in B18012: Diff 44214.Aug 11 2017, 4:49 PM

chad accepted this revision.Aug 11 2017, 5:21 PM

This revision is now accepted and ready to land.Aug 11 2017, 5:21 PM

Closed by commit rPef8d4e2126af: Fix an inverted condition for the "Reopen Revision" action (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionReopenTransaction.php

2 lines

Diff 44214

View Options

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

Fix an inverted condition for the "Reopen Revision" actionClosedPublicActions