Page MenuHomePhabricator
Differential D18399

Fix an inverted condition for the "Reopen Revision" action
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:48 PM.
Tags
None
Referenced Files
F15847265: D18399.diff
Sat, May 31, 3:15 AM
F15820796: D18399.id44241.diff
Fri, May 30, 6:23 PM
Unknown Object (File)
Thu, May 29, 8:12 AM
Unknown Object (File)
Wed, May 28, 8:45 AM
Unknown Object (File)
Apr 29 2025, 6:06 PM
Unknown Object (File)
Apr 29 2025, 1:21 PM
Unknown Object (File)
Apr 28 2025, 8:22 AM
Unknown Object (File)
Apr 27 2025, 9:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rPea4e33261e49: (stable) Fix an inverted condition for the "Reopen Revision" action
rPef8d4e2126af: Fix an inverted condition for the "Reopen Revision" action
Summary

Ref T2543. I converted this condition the wrong way, missing a !. I'll cherry-pick this to stable.

Test Plan

No more "Reopen Revision" action available on open revisions.

Diff Detail

Repository
rP Phabricator
Branch
status8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18012
Build 24195: Run Core Tests
Build 24194: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 4:48 PM
Harbormaster completed remote builds in B18012: Diff 44214.Aug 11 2017, 4:49 PM
chad accepted this revision.Aug 11 2017, 5:21 PM
This revision is now accepted and ready to land.Aug 11 2017, 5:21 PM
Closed by commit rPef8d4e2126af: Fix an inverted condition for the "Reopen Revision" action (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
xaction/
2 lines

Diff 44214

View Options

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

Loading...
Phabricator · Built by Phacility