Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F17800072: D18393.id44207.diff
Fri, Jul 25, 5:54 AM
F17794293: D18393.id.diff
Thu, Jul 24, 11:46 PM
F17781216: D18393.diff
Thu, Jul 24, 5:53 AM
F17731735: D18393.id44208.diff
Sun, Jul 20, 2:37 AM
F17716008: D18393.diff
Thu, Jul 17, 3:28 PM
Unknown Object (File)
Mon, Jun 30, 10:06 AM
Unknown Object (File)
May 31 2025, 11:00 AM
Unknown Object (File)
Apr 30 2025, 8:07 PM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
status2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18006
Build 24183: Run Core Tests
Build 24182: arc lint + arc unit